lib/console.c: strdup() to avoid arbitrary buffer sizestrdup

Signed-off-by: Alejandro Colomar <alx@kernel.org>

1 files changed, 10 insertions, 5 deletions

diff --git a/lib/console.c b/lib/console.c
index b1d58c97..1b6d35e5 100644
--- a/lib/console.c
+++ b/lib/console.c
@@ -44,16 +44,21 @@ static bool is_listed (const char *cfgin, const char *tty, bool def)
 	 */
 
 	if (*cons != '/') {
-		char *pbuf;
-		STRTCPY(buf, cons);
-		pbuf = &buf[0];
-		while ((s = strtok (pbuf, ":")) != NULL) {
+		char  *p;
+
+		p = strdup(cons);
+		if (p == NULL)
+			return def;
+
+		while ((s = strtok(p, ":")) != NULL) {
 			if (strcmp (s, tty) == 0) {
+				free(p);
 				return true;
 			}
 
-			pbuf = NULL;
+			p = NULL;
 		}
+		free(p);
 		return false;
 	}