diff options
| author | Alejandro Colomar <alx@nginx.com> | 2023-01-04 00:17:32 +0100 |
|---|---|---|
| committer | Alejandro Colomar <alx@nginx.com> | 2023-07-01 17:29:43 +0200 |
| commit | 182efeff5844855c4936d1947d87afb608ea040a (patch) | |
| tree | 52641a15e5cef939a5141734df93be4f862c0590 | |
| parent | d7e22a56ea0dde532d0fc6263dab8d8c5c8264cd (diff) | |
Isolation: reversed logic to improve readability.isolation
Cc: Tiago Natel de Moura <t.nateldemoura@f5.com>
Signed-off-by: Alejandro Colomar <alx@nginx.com>
| -rw-r--r-- | src/nxt_clone.c | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/src/nxt_clone.c b/src/nxt_clone.c index 0ad583e5..b4b1a403 100644 --- a/src/nxt_clone.c +++ b/src/nxt_clone.c @@ -288,18 +288,17 @@ nxt_clone_vldt_credential_gidmap(nxt_task_t *task, return NXT_OK; } - if (creds->ngroups > 0 - && !(creds->ngroups == 1 && creds->gids[0] == creds->base_gid)) + if (creds->ngroups == 0 + || (creds->ngroups == 1 && creds->gids[0] == creds->base_gid)) { - nxt_log(task, NXT_LOG_ERR, "\"gidmap\" field has no entries " - "but user \"%s\" has %d suplementary group%s.", - creds->user, creds->ngroups, - creds->ngroups > 1 ? "s" : ""); - - return NXT_ERROR; + return NXT_OK; } - return NXT_OK; + nxt_log(task, NXT_LOG_ERR, "\"gidmap\" field has no entries but user " + "\"%s\" has %d suplementary group%s.", + creds->user, creds->ngroups, creds->ngroups > 1 ? "s" : ""); + + return NXT_ERROR; } base_ok = 0; |