summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlejandro Colomar <alx@kernel.org>2024-01-18 11:15:17 +0100
committerSerge Hallyn <serge@hallyn.com>2024-03-14 16:16:15 -0500
commit88760598f079f945fc7b6c72786e3101fd4f45b1 (patch)
tree21b652bb97ec5445e97bfe33d5d3fb8fdb29532e
parentefd169e010f8c4dc7b6167e775dfae6b869150d5 (diff)
src/sulogin.c: Invert logic to reduce indentation
Also, it was checking for >=0 for success, but since that code is for opening a different tty as stdin, that was bogus. But since it's guaranteed to be either 0 or -1, this commit doesn't add any code to make sure it's 0 (i.e., we could say !=0 instead of ==-1). That's more appropriate for a different commit. Signed-off-by: Alejandro Colomar <alx@kernel.org>
-rw-r--r--src/sulogin.c10
1 files changed, 4 insertions, 6 deletions
diff --git a/src/sulogin.c b/src/sulogin.c
index 244a2acd..20971743 100644
--- a/src/sulogin.c
+++ b/src/sulogin.c
@@ -84,12 +84,10 @@ main(int argc, char *argv[])
close(1);
close(2);
- if (open(argv[1], O_RDWR) >= 0) {
- dup (0);
- dup (0);
- } else {
- exit (1);
- }
+ if (open(argv[1], O_RDWR) == -1)
+ exit(1);
+ dup(0);
+ dup(0);
}
if (access (PASSWD_FILE, F_OK) == -1) { /* must be a password file! */
(void) puts (_("No password file"));