summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTobias Stoeckmann <tobias@stoeckmann.org>2024-02-03 01:07:58 +0100
committerAlejandro Colomar <alx@kernel.org>2024-02-05 00:46:30 +0100
commitbc0151d4d30674224fab01884ba62f10a5b63084 (patch)
treeffb57dd0e8f01d842bccf129b6dd8e5ad039145a
parent4b775cbff9a8dc1b34a630dec493161e7a4cc716 (diff)
lib/chkname.c: Take NUL byte into account
The _SC_LOGIN_NAME_MAX value includes space for the NUL byte. The length of name must smaller than this value to be valid. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org> Cherry-picked-from: 403a2e3771be ("lib/chkname.c: Take NUL byte into account") Link: <https://github.com/shadow-maint/shadow/pull/935> Cc: Serge Hallyn <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
-rw-r--r--lib/chkname.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/chkname.c b/lib/chkname.c
index d22e1b6b..d14e44a5 100644
--- a/lib/chkname.c
+++ b/lib/chkname.c
@@ -80,7 +80,7 @@ bool is_valid_user_name (const char *name)
* User names length are limited by the kernel
*/
maxlen = sysconf(_SC_LOGIN_NAME_MAX);
- if (strlen(name) > maxlen)
+ if (strlen(name) >= maxlen)
return false;
return is_valid_name (name);