diff options
| author | Mark Johnston <markj@FreeBSD.org> | 2021-07-16 10:12:47 -0400 |
|---|---|---|
| committer | Tony Hutter <hutter2@llnl.gov> | 2021-09-22 15:19:08 -0700 |
| commit | 0c4f86be7416b9d5c571b99bb0313b730b2ca9f8 (patch) | |
| tree | d24f00a814b630f14e397af96d980eb258a45321 | |
| parent | 88be308b2ff98f032a6773d4530276687f5e38dc (diff) | |
Initialize dn_next_type[] in the dnode constructor
It seems nothing ensures that this array is zeroed when a dnode is
freshly allocated, so in principle it retains the values from the
previous allocation. In practice it seems to be the case that the
fields should end up zeroed, but we can zero the field anyway for
consistency.
This was found using KMSAN.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Mark Johnston <markj@FreeBSD.org>
Closes #12383
| -rw-r--r-- | module/zfs/dnode.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/module/zfs/dnode.c b/module/zfs/dnode.c index 23364dbae..5ad5be328 100644 --- a/module/zfs/dnode.c +++ b/module/zfs/dnode.c @@ -129,6 +129,7 @@ dnode_cons(void *arg, void *unused, int kmflag) zfs_refcount_create(&dn->dn_tx_holds); list_link_init(&dn->dn_link); + bzero(&dn->dn_next_type[0], sizeof (dn->dn_next_type)); bzero(&dn->dn_next_nblkptr[0], sizeof (dn->dn_next_nblkptr)); bzero(&dn->dn_next_nlevels[0], sizeof (dn->dn_next_nlevels)); bzero(&dn->dn_next_indblkshift[0], sizeof (dn->dn_next_indblkshift)); |