diff options
| author | Rich Ercolani <214141+rincebrain@users.noreply.github.com> | 2021-06-01 14:58:08 -0400 |
|---|---|---|
| committer | Tony Hutter <hutter2@llnl.gov> | 2021-06-01 17:18:13 -0700 |
| commit | 3e0bc63e1b0ca03493b936e92e871ca7ae451a0a (patch) | |
| tree | c37c00ee23a6b99a7afd468c71696295638d1357 | |
| parent | 9dc9bb377806c7f3f05c68517e86d508bc465797 (diff) | |
Remove iov_iter_advance() for iter_write
The additional iter advance is incorrect, as copy_from_iter() has
already done the right thing. This will result in the following
warning being printed to the console as of the 5.12 kernel.
Attempted to advance past end of bvec iter
This change should have been included with #11378 when a
similar change was made on the read side.
Suggested-by: @siebenmann
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Issue #11378
Closes #12041
Closes #12155
(cherry picked from commit 3f81aba7668143c6ca6fc44983d4c880606dea8f)
Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev>
| -rw-r--r-- | module/os/linux/zfs/zpl_file.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/module/os/linux/zfs/zpl_file.c b/module/os/linux/zfs/zpl_file.c index 08bf97ff3..e20c1dd41 100644 --- a/module/os/linux/zfs/zpl_file.c +++ b/module/os/linux/zfs/zpl_file.c @@ -342,9 +342,6 @@ zpl_iter_write(struct kiocb *kiocb, struct iov_iter *from) ssize_t wrote = count - uio.uio_resid; kiocb->ki_pos += wrote; - if (wrote > 0) - iov_iter_advance(from, wrote); - return (wrote); } |