From 0400e3d5cea76e4b99cb7ff593404286c463cc82 Mon Sep 17 00:00:00 2001 From: Maxim Dounin Date: Sun, 21 May 2023 04:38:45 +0300 Subject: QUIC: better sockaddr initialization. The qsock->sockaddr field is a ngx_sockaddr_t union, and therefore can hold any sockaddr (and union members, such qsock->sockaddr.sockaddr, can be used to access appropriate variant of the sockaddr). It is better to set it via qsock->sockaddr itself though, and not qsock->sockaddr.sockaddr, so static analyzers won't complain about out-of-bounds access. Prodded by Coverity (CID 1530403). --- src/event/quic/ngx_event_quic_udp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/event/quic/ngx_event_quic_udp.c b/src/event/quic/ngx_event_quic_udp.c index 71754a48b..15b54bc82 100644 --- a/src/event/quic/ngx_event_quic_udp.c +++ b/src/event/quic/ngx_event_quic_udp.c @@ -183,7 +183,7 @@ ngx_quic_recvmsg(ngx_event_t *ev) qsock = ngx_quic_get_socket(c); - ngx_memcpy(&qsock->sockaddr.sockaddr, sockaddr, socklen); + ngx_memcpy(&qsock->sockaddr, sockaddr, socklen); qsock->socklen = socklen; c->udp->buffer = &buf; -- cgit v1.2.3