diff options
| author | Valentin Bartenev <vbart@nginx.com> | 2016-06-16 20:55:11 +0300 |
|---|---|---|
| committer | Valentin Bartenev <vbart@nginx.com> | 2016-06-16 20:55:11 +0300 |
| commit | a70e415ea39c903f4c387e35faa71e2ac29a8e3c (patch) | |
| tree | c7b65b27136ae3bb4f117448354fd1c207f8e23e | |
| parent | a650907c17145c5fbbb3167a224de746f9b65233 (diff) | |
HTTP/2: fixed a segfault while processing unbuffered upload.
The ngx_http_v2_finalize_connection() closes current stream, but that is an
invalid operation while processing unbuffered upload. This results in access
to already freed memory, since the upstream module sets a cleanup handler that
also finalizes the request.
| -rw-r--r-- | src/http/v2/ngx_http_v2.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/http/v2/ngx_http_v2.c b/src/http/v2/ngx_http_v2.c index 208f0f325..94f57a717 100644 --- a/src/http/v2/ngx_http_v2.c +++ b/src/http/v2/ngx_http_v2.c @@ -4169,10 +4169,6 @@ ngx_http_v2_finalize_connection(ngx_http_v2_connection_t *h2c, c->error = 1; - if (h2c->state.stream) { - ngx_http_v2_close_stream(h2c->state.stream, NGX_HTTP_BAD_REQUEST); - } - if (!h2c->processing) { ngx_http_close_connection(c); return; |