summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlejandro Colomar <alx@kernel.org>2023-04-02 15:03:54 +0200
committerAlejandro Colomar <alx@kernel.org>2023-04-02 15:06:54 +0200
commit437a0ad8283d29ef2c8f59d08388c9aa4170b567 (patch)
tree1a0494dd12cf577e4afd26e9d87518edc0430f55
parent0afc6b902daf8178a7e3b7158319c630dda14d99 (diff)
verbose.mk: Fix warning from GNU Make 4.4
While '$(V).SILENT:' is a common idiom in make, it may be more explicit to put '.SILENT:' inside a conditional. Since we already used the conditional for something else, it's not a big change. As a nice side effect, vim now recognizes it and highlights it as a special target. With the old code, GNU Make 4.4 reported a warning about undefined variables: lib/verbose.mk:18: warning: undefined variable 'V' Signed-off-by: Alejandro Colomar <alx@kernel.org>
-rw-r--r--lib/verbose.mk4
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/verbose.mk b/lib/verbose.mk
index 38180804f..af2fe154f 100644
--- a/lib/verbose.mk
+++ b/lib/verbose.mk
@@ -12,10 +12,8 @@ ifdef V
HIDE_ERR :=
else
HIDE_ERR := 2>/dev/null
+.SILENT:
endif
-$(V).SILENT:
-
-
endif # MAKEFILE_VERBOSE_INCLUDED