diff options
author | Alejandro Colomar <alx.manpages@gmail.com> | 2021-11-19 19:15:35 +0100 |
---|---|---|
committer | Alejandro Colomar <alx.manpages@gmail.com> | 2021-11-20 14:45:32 +0100 |
commit | d2f0dc48706ba5d89dad5ed9eab4f7d21591497a (patch) | |
tree | dae7902826086868bc7933af57a04d60c6816b48 | |
parent | 11760b380c354f5451b83dd903086acc369aab8d (diff) |
tools/testing/selftests/bpf/: Don't redefine ARRAY_SIZE()
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
6 files changed, 12 insertions, 22 deletions
diff --git a/tools/testing/selftests/bpf/bpf_util.h b/tools/testing/selftests/bpf/bpf_util.h index 394377e4aa14..993ce57aa0fa 100644 --- a/tools/testing/selftests/bpf/bpf_util.h +++ b/tools/testing/selftests/bpf/bpf_util.h @@ -7,6 +7,7 @@ #include <string.h> #include <errno.h> #include <bpf/libbpf.h> /* libbpf_num_possible_cpus */ +#include <linux/array_size.h> #include <linux/offsetofend.h> #include <linux/sizeof_field.h> @@ -29,9 +30,5 @@ static inline unsigned int bpf_num_possible_cpus(void) name[bpf_num_possible_cpus()] #define bpf_percpu(name, cpu) name[(cpu)].v -#ifndef ARRAY_SIZE -# define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) -#endif - #endif /* __BPF_UTIL__ */ diff --git a/tools/testing/selftests/bpf/progs/netif_receive_skb.c b/tools/testing/selftests/bpf/progs/netif_receive_skb.c index 1d8918dfbd3f..6e2e614cdbaf 100644 --- a/tools/testing/selftests/bpf/progs/netif_receive_skb.c +++ b/tools/testing/selftests/bpf/progs/netif_receive_skb.c @@ -1,13 +1,16 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (c) 2020, Oracle and/or its affiliates. */ + #include "btf_ptr.h" #include <bpf/bpf_helpers.h> #include <bpf/bpf_tracing.h> #include <bpf/bpf_core_read.h> +#include <linux/array_size.h> #include <errno.h> + long ret = 0; int num_subtests = 0; int ran_subtests = 0; @@ -23,10 +26,6 @@ bool skip = false; #define BADPTR 0 #endif -#ifndef ARRAY_SIZE -#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) -#endif - struct { __uint(type, BPF_MAP_TYPE_PERCPU_ARRAY); __uint(max_entries, 1); diff --git a/tools/testing/selftests/bpf/progs/profiler.inc.h b/tools/testing/selftests/bpf/progs/profiler.inc.h index ba85b13afbdd..0b25ab557d2e 100644 --- a/tools/testing/selftests/bpf/progs/profiler.inc.h +++ b/tools/testing/selftests/bpf/progs/profiler.inc.h @@ -2,6 +2,7 @@ /* Copyright (c) 2020 Facebook */ +#include <linux/array_size.h> #include <linux/NULL.h> #include <vmlinux.h> #include <bpf/bpf_core_read.h> @@ -132,10 +133,6 @@ struct { __uint(max_entries, 16); } disallowed_exec_inodes SEC(".maps"); -#ifndef ARRAY_SIZE -#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0])) -#endif - static INLINE bool IS_ERR(const void* ptr) { return IS_ERR_VALUE((unsigned long)ptr); diff --git a/tools/testing/selftests/bpf/progs/test_sysctl_loop1.c b/tools/testing/selftests/bpf/progs/test_sysctl_loop1.c index 553a282d816a..9aa273fb447f 100644 --- a/tools/testing/selftests/bpf/progs/test_sysctl_loop1.c +++ b/tools/testing/selftests/bpf/progs/test_sysctl_loop1.c @@ -1,17 +1,16 @@ // SPDX-License-Identifier: GPL-2.0 // Copyright (c) 2019 Facebook + #include <stdint.h> #include <string.h> +#include <linux/array_size.h> #include <linux/stddef.h> #include <linux/bpf.h> #include <bpf/bpf_helpers.h> -#ifndef ARRAY_SIZE -#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) -#endif /* tcp_mem sysctl has only 3 ints, but this test is doing TCP_MEM_LOOPS */ #define TCP_MEM_LOOPS 28 /* because 30 doesn't fit into 512 bytes of stack */ diff --git a/tools/testing/selftests/bpf/progs/test_sysctl_loop2.c b/tools/testing/selftests/bpf/progs/test_sysctl_loop2.c index 2b64bc563a12..4afcaf47c79e 100644 --- a/tools/testing/selftests/bpf/progs/test_sysctl_loop2.c +++ b/tools/testing/selftests/bpf/progs/test_sysctl_loop2.c @@ -1,17 +1,16 @@ // SPDX-License-Identifier: GPL-2.0 // Copyright (c) 2019 Facebook + #include <stdint.h> #include <string.h> +#include <linux/array_size.h> #include <linux/stddef.h> #include <linux/bpf.h> #include <bpf/bpf_helpers.h> -#ifndef ARRAY_SIZE -#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) -#endif /* tcp_mem sysctl has only 3 ints, but this test is doing TCP_MEM_LOOPS */ #define TCP_MEM_LOOPS 20 /* because 30 doesn't fit into 512 bytes of stack */ diff --git a/tools/testing/selftests/bpf/progs/test_sysctl_prog.c b/tools/testing/selftests/bpf/progs/test_sysctl_prog.c index 5489823c83fc..97982bbb95b2 100644 --- a/tools/testing/selftests/bpf/progs/test_sysctl_prog.c +++ b/tools/testing/selftests/bpf/progs/test_sysctl_prog.c @@ -1,24 +1,23 @@ // SPDX-License-Identifier: GPL-2.0 // Copyright (c) 2019 Facebook + #include <stdint.h> #include <string.h> +#include <linux/array_size.h> #include <linux/stddef.h> #include <linux/bpf.h> #include <bpf/bpf_helpers.h> + /* Max supported length of a string with unsigned long in base 10 (pow2 - 1). */ #define MAX_ULONG_STR_LEN 0xF /* Max supported length of sysctl value string (pow2). */ #define MAX_VALUE_STR_LEN 0x40 -#ifndef ARRAY_SIZE -#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) -#endif - const char tcp_mem_name[] = "net/ipv4/tcp_mem"; static __always_inline int is_tcp_mem(struct bpf_sysctl *ctx) { |