diff options
| author | Volodymyr Sapsai <vsapsai@gmail.com> | 2017-01-22 13:33:13 -0800 |
|---|---|---|
| committer | Volodymyr Sapsai <vsapsai@gmail.com> | 2017-01-28 16:53:14 -0800 |
| commit | 1007562363756627cdab664124e37669dfbf0c6b (patch) | |
| tree | e514a6f35a6d515473fd9fa3c890dfd1b12c40d7 | |
| parent | 4e957bf33a337f5fe5e275a354cfc46650e11ac2 (diff) | |
Remove I1_Class requirement for calling operator==.
operator== calls I1_const_ptr<T>::operator* and after Clang r289250 we
correctly detect that the return type of
const T& operator*() { return *ptr_; }
is LValueReferenceType and doesn't require full type use.
PR https://github.com/include-what-you-use/include-what-you-use/pull/399
| -rw-r--r-- | tests/cxx/badinc.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/tests/cxx/badinc.cc b/tests/cxx/badinc.cc index 39253cd..6dfc2e2 100644 --- a/tests/cxx/badinc.cc +++ b/tests/cxx/badinc.cc @@ -1492,15 +1492,9 @@ int main() { // IWYU: I1_const_ptr is...*badinc-i1.h local_i1_const_ptr.indirect_del(); // This calls *ptr_, but in a free function. - // TODO(chandlerc): The I1_Class requirement below may be necessary, but is - // not being added for the correct reasons even if so. - // IWYU: I1_Class is...*badinc-i1.h // IWYU: operator== is...*badinc-i1.h // IWYU: I1_const_ptr is...*badinc-i1.h (void)(local_i1_const_ptr == i1_class); - // TODO(chandlerc): The I1_Class requirement below may be necessary, but is - // not being added for the correct reasons even if so. - // IWYU: I1_Class is...*badinc-i1.h // IWYU: operator== is...*badinc-i1.h // IWYU: I1_const_ptr is...*badinc-i1.h (void)(i1_class == local_i1_const_ptr); |