From ef2a2f8a66ad1a32a3dbb6c914cad59097468af7 Mon Sep 17 00:00:00 2001 From: Alejandro Colomar Date: Thu, 2 Nov 2023 18:52:04 +0100 Subject: bin/grepc: Improve error messages Signed-off-by: Alejandro Colomar --- bin/grepc | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/bin/grepc b/bin/grepc index 374915b..d6126db 100755 --- a/bin/grepc +++ b/bin/grepc @@ -24,9 +24,10 @@ t_use_macro='no'; t_use_type='no'; -grepc_usage() +grepc_err() { - echo "Usage: $0 [OPTION ...] IDENTIFIER [FILE ...]"; + >&2 echo "$(basename "$0"): error: $*"; + exit 1; } @@ -41,7 +42,7 @@ grepc_parse_cmd() git='yes'; ;; h) - grepc_usage; + echo "Usage: $0 [OPTION ...] IDENTIFIER [FILE ...]"; exit 0; ;; i) @@ -118,8 +119,7 @@ grepc_parse_cmd() t_use_type='yes'; ;; *) - grepc_usage; - exit 1; + grepc_err "-$opt: $OPTARG: Unknown argument."; ;; esac; tflag='yes'; @@ -128,17 +128,13 @@ grepc_parse_cmd() ext="$OPTARG"; ;; ?) - grepc_usage >&2; - exit 1; + exit 1; # getopts(1) prints an error msg. ;; esac; done; shift $((OPTIND-1)); - if [ $# -lt 1 ]; then - grepc_usage >&2; - exit 1; - fi; + test $# -lt 1 && grepc_err "Missing identifier."; identifier=$1; shift; -- cgit v1.2.3